Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql/pgwire: add regression test for varchar OIDs in RowDescription #52352

Merged
merged 1 commit into from
Aug 5, 2020

Conversation

rafiss
Copy link
Collaborator

@rafiss rafiss commented Aug 4, 2020

See issue #51360. The bug described in it was fixed somewhat
accidentally, so this test will verify that we don't regress again.

Release note: None

@rafiss rafiss requested a review from jordanlewis August 4, 2020 18:08
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Member

@jordanlewis jordanlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @jordanlewis and @rafiss)


pkg/sql/pgwire/testdata/pgtest/row_description, line 220 at r1 (raw file):

{"Type":"ReadyForQuery","TxStatus":"I"}

# tab4 is a regression test for #51360

Please include a brief description of the issue so its more obvious what this test is doing without having to go to GitHub

See issue cockroachdb#51360. The bug described in it was fixed somewhat
accidentally, do this test will verify that we don't regress again.

Release note: None
@rafiss rafiss force-pushed the regression-51360 branch from c37668d to b960095 Compare August 4, 2020 22:08
Copy link
Collaborator Author

@rafiss rafiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @jordanlewis)


pkg/sql/pgwire/testdata/pgtest/row_description, line 220 at r1 (raw file):

Previously, jordanlewis (Jordan Lewis) wrote…

Please include a brief description of the issue so its more obvious what this test is doing without having to go to GitHub

Done

@rafiss
Copy link
Collaborator Author

rafiss commented Aug 5, 2020

bors r=jordanlewis

@craig
Copy link
Contributor

craig bot commented Aug 5, 2020

Build succeeded:

@craig craig bot merged commit 67a92cd into cockroachdb:master Aug 5, 2020
@rafiss rafiss deleted the regression-51360 branch August 11, 2020 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants