sql/catalog/lease: attempt to fix a flakey test #52408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
FWIW I stress-raced this and couldn't repro it. |
ajwerner
force-pushed
the
ajwerner/fix-bad-behavior-when-lease-test-fails
branch
from
3163cac to
ca97990
Compare
|
I'd also say that this doesn't actually fix the test it's just going to give more insights if it fails again instead of just blocking forever. |
thoszhang
approved these changes
Aug 5, 2020
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained
I think this test was going to fail. Fixes cockroachdb#52385. Release note: None
ajwerner
force-pushed
the
ajwerner/fix-bad-behavior-when-lease-test-fails
branch
from
ca97990 to
f5e8798
Compare
|
TFTR! bors r=lucy-zhang |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this test was going to fail.
Fixes #52385.
Release note: None