kv/kvtenant: rename Proxy to Connector #52599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
tbg
approved these changes
Aug 11, 2020
nvanbenschoten
force-pushed
the
nvanbenschoten/proxyConnector
branch
from
c009f64 to
e82c0a7
Compare
See discussion in cockroachdb#50503. We found "proxy" confusing, because the object was in the same process as the rest of the SQL-only process instead of run as a stand-alone component. "Connector" doesn't create the same confusion.
nvanbenschoten
force-pushed
the
nvanbenschoten/proxyConnector
branch
from
e82c0a7 to
5416c9c
Compare
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion in #50503. We found "proxy" confusing, because the object was
in the same process as the rest of the SQL-only process instead of run as a
stand-alone component. "Connector" doesn't create the same confusion.