Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

geo/geomfn: implement ST_SymmetricDifference #53688

Merged
merged 1 commit into from
Sep 1, 2020

Conversation

CyrusJavan
Copy link
Contributor

Added ST_SymmetricDifference builtin.

ST_SymmetricDifference is simply an alias for ST_SymDifference.

Release justification: low-risk update to new functionality
Release note (sql change): Implemented the geometry based builtin
ST_SymmetricDifference.

Resolves: #49052

@blathers-crl
Copy link

blathers-crl bot commented Aug 31, 2020

Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR.

My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI.

I have added a few people who may be able to assist in reviewing:

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@blathers-crl blathers-crl bot added O-community Originated from the community X-blathers-triaged blathers was able to find an owner labels Aug 31, 2020
@blathers-crl blathers-crl bot requested a review from otan August 31, 2020 16:58
@cockroach-teamcity
Copy link
Member

This change is Reviewable

SELECT
a.dsc,
b.dsc,
ST_AsEWKT(ST_Intersection(a.geom, b.geom)),
ST_Intersection(a.geom, b.geom) = ST_Intersection(a.geom::string, b.geom::string),
ST_AsEWKT(ST_SymDifference(a.geom, b.geom))
ST_AsEWKT(ST_SymDifference(a.geom, b.geom)),
ST_AsEWKT(ST_SymmetricDifference(a.geom, b.geom))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! quick comment -- can you move both these symdifference statements to a separate select?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done 👍

Added ST_SymmetricDifference builtin.

ST_SymmetricDifference is simply an alias for ST_SymDifference.

Release justification: low-risk update to new functionality
Release note (sql change): Implemented the geometry based builtin .

Resolves: cockroachdb#49052
@blathers-crl
Copy link

blathers-crl bot commented Aug 31, 2020

Thank you for updating your pull request.

My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@otan
Copy link
Contributor

otan commented Aug 31, 2020

bors r+

thanks!

@craig
Copy link
Contributor

craig bot commented Aug 31, 2020

This PR was included in a batch that was canceled, it will be automatically retried

@craig
Copy link
Contributor

craig bot commented Sep 1, 2020

Build succeeded:

@craig craig bot merged commit f2056ba into cockroachdb:master Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-community Originated from the community X-blathers-triaged blathers was able to find an owner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

geo/geomfn: implement ST_SymmetricDifference({geometry,geometry})
3 participants