geos: do not set 3D on EWKB writer #53909
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
This seems to do weird things on certain systems if a GEOMETRYCOLLECTION contains an EMPTY element. The corollary of this is WKTs which are given 3D/4D "lose" their 3D/4D component. I think this will have to be a docs limitation. Release justification: low risk update to new functionality Release note: None
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
geos: do not set 3D on EWKB writer
This seems to do weird things on certain systems if a GEOMETRYCOLLECTION
contains an EMPTY element.
The corollary of this is WKTs which are given 3D/4D "lose" their 3D/4D
component. I think this will have to be a docs limitation.
Since we don't support 3D/4D properly anyway, added a note to #53091.
Release justification: low risk update to new functionality
Release note: None