bulkio: Count corrupt schedules. #54041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
dt
approved these changes
Sep 16, 2020
|
I think I'd feel slightly better calling it "unreadable" or "malformed", just since "corrupt" makes it sounds like cockroach is losing bytes or something, but my guess is usually it's going to be more likely a proto change/version skew problem. Same result, but "corrupt" is just a scary word to throw around when I'm guessing it's simply "unreadable [... by this version]" or "malformed [... according to this version]". /2¢. |
|
Good point -- names changed to make them less scary. |
miretskiy
force-pushed
the
metrics
branch
2 times, most recently
from
7270b9a
to
4dfedb6
Compare
Differentiate between "bad schedules" -- schedules we could not execute, and corrupt ones (schedules we couldn't even parse). Release Notes: None Release Justification: No impact metrics change.
dt
approved these changes
Sep 29, 2020
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differentiate between "bad schedules" -- schedules
we could not execute, and corrupt ones (schedules
we couldn't even parse).
Release Notes: None
Release Justification: No impact metrics change.