roachtest: unskip cdc/crdb-chaos #54201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
I'm unsure if I should close #37716 right now with this PR since it has some discussion that might be helpful in case the test fails again. I'll close it if we don't see the issue pop up again in the next few days. |
andreimatei
reviewed
Sep 10, 2020
There was a problem hiding this comment.
I'm pretty scared about those 15 minutes, so if you ever find yourself with time on your hands there's probably something there.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @andreimatei and @nvanbenschoten)
nvanbenschoten
approved these changes
Sep 10, 2020
aayushshah15
force-pushed
the
rangefeed_latency
branch
from
e50213a
to
ce48e9e
Compare
I ran this test a total of 15 times in parallel and wasn't able to reproduce. Since its been skipped for 2+ releases, it's hard to know what fixed it, but a good guess is cockroachdb#48561. Release note: None Fixes cockroachdb#37716 Release justification: testing only
aayushshah15
force-pushed
the
rangefeed_latency
branch
from
ce48e9e
to
51d31c1
Compare
|
I ran 4 instances of this with the target latency set to 5 minutes and they all passed just fine. So I've reduced this target in this PR. We'll see if this pops up again in CI. |
|
(Bump) |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran this test a total of 15 times in parallel and wasn't able to
reproduce. Since its been skipped for 2+ releases, it's hard to know
what fixed it, but a good guess is #48561.
Release note: None
Fixes #37716
Informs #36879
Release justification: testing only