Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: auto-generate documentation for the logging output formats #58075

Merged
merged 1 commit into from
Dec 30, 2020

Conversation

knz
Copy link
Contributor

@knz knz commented Dec 18, 2020

Example output documentation here: https://github.com/knz/cockroach/blob/20201218-fmt-doc/docs/generated/logformats.md

Release note (doc change): The various output formats available
for logging configurations are now documented.
See the reference documentation for details.

@knz knz requested a review from itsbilal December 18, 2020 18:41
@knz knz requested a review from a team as a code owner December 18, 2020 18:41
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@knz knz force-pushed the 20201218-fmt-doc branch 4 times, most recently from 466ed87 to 5ec7a93 Compare December 21, 2020 13:27
@knz knz force-pushed the 20201218-fmt-doc branch 2 times, most recently from 8ed3c68 to 091e388 Compare December 22, 2020 16:13
Release note (doc change): The various output formats available
for logging configurations are now documented.
See the reference documentation for details.
Copy link
Member

@itsbilal itsbilal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 7 of 7 files at r1.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

@knz
Copy link
Contributor Author

knz commented Dec 30, 2020

fantastic, thank you!

bors r=itsbilal

@craig
Copy link
Contributor

craig bot commented Dec 30, 2020

Build succeeded:

@craig craig bot merged commit cd5f214 into cockroachdb:master Dec 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants