Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-20.2: sql/rowexec: don't allocate buf per row in sketchInfo.addRow #58197

Merged

Commits on Dec 22, 2020

  1. sql/rowexec: don't allocate buf per row in sketchInfo.addRow

    The `intbuf` array was meant to stay on the stack, but was escaping
    to the heap because the call through the `hash` function variable was
    opaque to escape analysis.
    
    At the end of a 4 hour, 2.2 TB IMPORT of TPC-E, this was responsible
    for **76.70%** of all heap allocations.
    
    Release note (performance improvement): SQL statistics collection
    has been made more efficient by avoiding an accidental heap allocation
    per row for some schemas.
    nvanbenschoten committed Dec 22, 2020
    Configuration menu
    Copy the full SHA
    4be5967 View commit details
    Browse the repository at this point in the history