Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tracing: add package-level documentation for tracing concepts #58516

Merged
merged 2 commits into from
Jan 8, 2021

Conversation

irfansharif
Copy link
Contributor

First two commits are from #58509, and can be ignored here.

Release note: None

@irfansharif irfansharif requested review from knz and tbg January 6, 2021 22:35
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Member

@tbg tbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Reviewed 7 of 7 files at r1, 5 of 5 files at r2, 1 of 1 files at r3, 8 of 8 files at r4.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @irfansharif and @knz)


pkg/util/tracing/doc.go, line 53 at r4 (raw file):

//                          way depend on the result of the second (think of a
//                          goroutine that spins off another that outlives it).
//                          Somewhat confusingly, we still refer to the "first"

It's not that confusing when you consider that even with a parent-child relation, you can still have the child outlive the parent (you shouldn't - but there's nothing stopping you). The relation type, as far as I can tell, is really more of a hint than something that materially effects how the span works.

@tbg tbg force-pushed the 210106.document-pkg-tracing branch 3 times, most recently from 3f8547e to 36fb923 Compare January 7, 2021 10:04
@irfansharif irfansharif force-pushed the 210106.document-pkg-tracing branch 2 times, most recently from 2c0ab9a to 3506f45 Compare January 8, 2021 02:50
@irfansharif
Copy link
Contributor Author

bors r+

@craig
Copy link
Contributor

craig bot commented Jan 8, 2021

Build failed:

@irfansharif
Copy link
Contributor Author

bors r+

@craig
Copy link
Contributor

craig bot commented Jan 8, 2021

Build failed:

@irfansharif
Copy link
Contributor Author

#58211, sigh.

bors r+

@craig
Copy link
Contributor

craig bot commented Jan 8, 2021

Build failed:

@irfansharif
Copy link
Contributor Author

bors r+

@craig
Copy link
Contributor

craig bot commented Jan 8, 2021

Build failed:

And sneak in some miscellaneous cleanups.

Release note: None
@irfansharif
Copy link
Contributor Author

bors r+

craig bot pushed a commit that referenced this pull request Jan 8, 2021
58516: tracing: add package-level documentation for tracing concepts r=irfansharif a=irfansharif

First two commits are from #58509, and can be ignored here.

Release note: None

Co-authored-by: irfan sharif <irfanmahmoudsharif@gmail.com>
@craig
Copy link
Contributor

craig bot commented Jan 8, 2021

Build failed:

@irfansharif
Copy link
Contributor Author

This has to be my unluckiest PR to date, now with:

BenchmarkPgCopyConvertRecord
panic: runtime error: slice bounds out of range [1:0]

bors r+

@craig
Copy link
Contributor

craig bot commented Jan 8, 2021

Build succeeded:

@craig craig bot merged commit 7826689 into cockroachdb:master Jan 8, 2021
@irfansharif irfansharif deleted the 210106.document-pkg-tracing branch January 8, 2021 15:43
@lunevalex lunevalex added the A-tracing Relating to tracing in CockroachDB. label Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tracing Relating to tracing in CockroachDB.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants