-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tracing: add package-level documentation for tracing concepts #58516
tracing: add package-level documentation for tracing concepts #58516
Conversation
e333b04
to
36fb923
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Reviewed 7 of 7 files at r1, 5 of 5 files at r2, 1 of 1 files at r3, 8 of 8 files at r4.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @irfansharif and @knz)
pkg/util/tracing/doc.go, line 53 at r4 (raw file):
// way depend on the result of the second (think of a // goroutine that spins off another that outlives it). // Somewhat confusingly, we still refer to the "first"
It's not that confusing when you consider that even with a parent-child relation, you can still have the child outlive the parent (you shouldn't - but there's nothing stopping you). The relation type, as far as I can tell, is really more of a hint than something that materially effects how the span works.
3f8547e
to
36fb923
Compare
Release note: None
2c0ab9a
to
3506f45
Compare
bors r+ |
Build failed: |
bors r+ |
Build failed: |
#58211, sigh. bors r+ |
Build failed: |
3506f45
to
6e0773b
Compare
bors r+ |
Build failed: |
And sneak in some miscellaneous cleanups. Release note: None
6e0773b
to
e9e1f2b
Compare
bors r+ |
Build failed: |
This has to be my unluckiest PR to date, now with:
bors r+ |
Build succeeded: |
First two commits are from #58509, and can be ignored here.
Release note: None