-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
geo/wkt: add support for parsing linestrings with Z and M dimensions #59740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyyang890
commented
Feb 3, 2021
otan
reviewed
Feb 3, 2021
andyyang890
force-pushed
the
wkt_parse_linestring
branch
from
February 4, 2021 01:41
7573502
to
1f300dd
Compare
andyyang890
force-pushed
the
wkt_parse_linestring
branch
from
February 4, 2021 01:50
1f300dd
to
35c9dad
Compare
otan
approved these changes
Feb 4, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is really awesome!
otan
reviewed
Feb 4, 2021
This patch extends the capabilities of the WKT parser to include parsing of linestrings with Z and M dimensions. This patch also improves the error messages generated for parsing errors. Release note: None
andyyang890
force-pushed
the
wkt_parse_linestring
branch
from
February 4, 2021 03:18
35c9dad
to
73a7fa5
Compare
otan
approved these changes
Feb 4, 2021
bors r=otan |
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch extends the capabilities of the WKT parser to include
parsing of linestrings with Z and M dimensions. This patch also
improves the error messages generated for parsing errors.
Refs: #53091
Release note: None