Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

geo/wkt: add support for parsing linestrings with Z and M dimensions #59740

Merged
merged 1 commit into from
Feb 4, 2021

Conversation

andyyang890
Copy link
Collaborator

@andyyang890 andyyang890 commented Feb 3, 2021

This patch extends the capabilities of the WKT parser to include
parsing of linestrings with Z and M dimensions. This patch also
improves the error messages generated for parsing errors.

Refs: #53091

Release note: None

@andyyang890 andyyang890 requested a review from otan February 3, 2021 01:02
@cockroach-teamcity
Copy link
Member

This change is Reviewable

pkg/geo/wkt/wkt.y Outdated Show resolved Hide resolved
pkg/geo/wkt/wkt.y Outdated Show resolved Hide resolved
pkg/geo/wkt/wkt.y Outdated Show resolved Hide resolved
pkg/geo/wkt/wkt_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

@otan otan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is really awesome!

pkg/geo/wkt/generate.sh Outdated Show resolved Hide resolved
pkg/geo/wkt/generate.sh Outdated Show resolved Hide resolved
This patch extends the capabilities of the WKT parser to include
parsing of linestrings with Z and M dimensions. This patch also
improves the error messages generated for parsing errors.

Release note: None
@andyyang890
Copy link
Collaborator Author

bors r=otan

@craig
Copy link
Contributor

craig bot commented Feb 4, 2021

Build succeeded:

@craig craig bot merged commit 100c09f into cockroachdb:master Feb 4, 2021
@andyyang890 andyyang890 deleted the wkt_parse_linestring branch February 4, 2021 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants