opt: fix panic in GenerateLookupJoin #59741
Conversation
|
This change is |
mgartner
force-pushed
the
fix-lookup-join
branch
from
18b4358
to
1288a1d
Compare
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @rytaft)
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, 2 of 2 files at r2.
Reviewable status:
pkg/sql/opt/xform/testdata/rules/join, line 3178 at r1 (raw file):
# Regression test for #59738. findConstantFilterCols should not panic when # it finds constant filters that are not in the scanned table.
[nit] this comment is a bit confusing. Instead of "scanned table", maybe say "index of the lookup join"?
In cockroachdb#57690 a new code path was introduced from `findConstantFilterCols` from `GenerateLookupJoins`. This new code path made it possible for the filters passed to `findConstantFilterCols` to contain columns that are not part of the given table. This violated the assumption that the filter only contains columns in the given table and caused a panic. This commit fixes the issue by neglecting constant filters for columns not in the given table. Fixes cockroachdb#59738 Release note (bug fix): A bug has been fixed that caused errors when joining two tables when one of the tables had a computed column. This bug was present since version 21.1.0-alpha.2 and not present in any production releases.
Release note: None
mgartner
force-pushed
the
fix-lookup-join
branch
from
1288a1d
to
7612677
Compare
There was a problem hiding this comment.
Reviewable status:
pkg/sql/opt/xform/testdata/rules/join, line 3178 at r1 (raw file):
Previously, rytaft (Rebecca Taft) wrote…
[nit] this comment is a bit confusing. Instead of "scanned table", maybe say "index of the lookup join"?
Done.
There was a problem hiding this comment.
Reviewed 1 of 3 files at r3, 2 of 2 files at r4.
Reviewable status:
|
TFTRs! bors r+ |
|
Build succeeded: |
opt: fix panic in GenerateLookupJoin
In #57690 a new code path was introduced from
findConstantFilterColsfrom
GenerateLookupJoins. This new code path made it possible for thefilters passed to
findConstantFilterColsto contain columns that arenot part of the given table. This violated the assumption that the
filter only contains columns in the given table and caused a panic. This
commit fixes the issue by neglecting constant filters for columns not in
the given table.
Fixes #59738
Release note (bug fix): A bug has been fixed that caused errors when
joining two tables when one of the tables had a computed column. This
bug was present since version 21.1.0-alpha.2 and not present in any
production releases.
opt: move findConstantFilterCols to general_funcs.go
Release note: None