Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

colmem: limit batches of dynamic size by workmem in memory footprint #59851

Merged
merged 1 commit into from
Feb 14, 2021

Commits on Feb 14, 2021

  1. colmem: limit batches of dynamic size by workmem in memory footprint

    This commit adds a minor improvement to `ResetMaybeReallocate` method so
    that it reuses the old batch (without doubling the capacity and
    allocating a new batch) when the old batch has enough capacity and
    reached the provided limit in size. This change effectively allows us to
    limit all batches flowing through the vectorized engine by `workmem`
    setting in size since the main batch-producers (cfetcher and
    columnarizer) use this method.
    
    Release note (sql change): Most batches of data flowing through the
    vectorized execution engine will now be limited in size by
    `sql.distsql.temp_storage.workmem` (64MiB by default) which should
    improve the stability of CockroachDB clusters.
    yuzefovich committed Feb 14, 2021
    Configuration menu
    Copy the full SHA
    9bbbce4 View commit details
    Browse the repository at this point in the history