Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sqlutil: remove Query and QueryEx from InternalExecutor interface #60428

Merged
merged 1 commit into from
Feb 10, 2021

Commits on Feb 10, 2021

  1. sqlutil: remove Query and QueryEx from InternalExecutor interface

    All usages of `sqlutil.InternalExecutor.Query` and
    `sqlutil.InternalExecutor.QueryEx` have been refactored: most of
    the changes are taking advantage of the iterator API, in a couple
    of places we now use `Exec` and `ExecEx` methods since in those
    places we only need the number of affected rows.
    
    In a few places where we still need to buffer all rows, the caller
    currently performs the buffering. In the follow-up commit
    `QueryBuffered` and `QueryBufferedEx` will be added into the interface
    (essentially renaming `Query` and `QueryEx` to make it explicit that the
    buffering occurs), and the custom logic will be removed.
    
    Release note: None
    yuzefovich committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    1be6518 View commit details
    Browse the repository at this point in the history