Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

logictest: deflake crdb_internal.gossip_liveness test #60443

Merged
merged 1 commit into from
Feb 10, 2021
Merged

logictest: deflake crdb_internal.gossip_liveness test #60443

merged 1 commit into from
Feb 10, 2021
+2 −2

Conversation

rafiss
Copy link
Collaborator

@rafiss rafiss commented Feb 10, 2021

The regex needs to also match 0,0

Release note: None

@rafiss
logictest: deflake crdb_internal.gossip_liveness test
095b7a4 
The regex needs to also match `0,0`

Release note: None
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rafiss
Copy link
Collaborator Author

rafiss commented Feb 10, 2021

See https://teamcity.cockroachdb.com/viewLog.html?buildId=2663952&buildTypeId=Cockroach_UnitTests for example flake

@rafiss
Copy link
Collaborator Author

rafiss commented Feb 10, 2021

ty!

bors r=otan

@craig
Copy link
Contributor

craig bot commented Feb 10, 2021

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Feb 10, 2021

This PR was included in a batch that was canceled, it will be automatically retried

@craig
Copy link
Contributor

craig bot commented Feb 10, 2021

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Feb 10, 2021

Build succeeded:

@craig craig bot merged commit 0ee3587 into cockroachdb:master Feb 10, 2021
@rafiss rafiss deleted the deflake-gossip-liveness branch February 22, 2021 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@otan otan otan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rafiss @cockroach-teamcity @otan