sqlutil: remove QueryWithCols in favor of QueryRowExWithCols #60572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
miretskiy
approved these changes
Feb 16, 2021
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @yuzefovich)
pkg/jobs/job_scheduler.go, line 307 at r1 (raw file):
// The loop below might encounter an error after some schedules have been // executed (i.e. previous iterations succeeded), and this is ok. // TODO(yuzefovich): confirm with Yevgeniy.
Yup. Should be fine. Each schedule executed under savepoint to guard against errors in schedule
planning/execution.
This commit refactors all usages of `sqlutil.InternalExecutor.QueryWithCols` method in favor of newly added `QueryRowExWithCols` since in almost all places where the former was used, we expected exactly one row. The only noticeable change is the refactor of `jobScheduler.executeSchedules` where we now use the iterator pattern. The difference there is that now it is possible to execute some schedules before encountering an error on the iterator (previously, we would buffer up all rows first), but this change is acceptable because each schedule is executed under savepoint to guard against errors in schedule planning/execution. Release note: None
yuzefovich
commented
Feb 16, 2021
There was a problem hiding this comment.
TFTR!
bors r+
Reviewable status:
pkg/jobs/job_scheduler.go, line 307 at r1 (raw file):
Previously, miretskiy (Yevgeniy Miretskiy) wrote…
Yup. Should be fine. Each schedule executed under savepoint to guard against errors in schedule
planning/execution.
👍
|
bors r- Forgot to update PR description. |
|
Canceled. |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit refactors all usages of
sqlutil.InternalExecutor.QueryWithColsmethod in favor of newly addedQueryRowExWithColssince in almost all places where the former wasused, we expected exactly one row. The only noticeable change is the
refactor of
jobScheduler.executeScheduleswhere we now use theiterator pattern. The difference there is that now it is possible to
execute some schedules before encountering an error on the iterator
(previously, we would buffer up all rows first), but this change is
acceptable because each schedule is executed under savepoint to guard
against errors in schedule planning/execution.
Addresses: #48595.
Release note: None