sql: remove QueryWithCols method from the internal executor #60604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous commit removed this method from the interface, and this commit follows up to remove the method entirely. This is done in a similar fashion - by changing to using `QueryRowExWithCols` (when at most one row is expected) and to using the iterator API (avoiding the buffering of rows in all cases). Release note: None
|
This change is |
|
Friends, could one of you take a look at this please? (I accepted all suggestions of the GitHub about reviewers.) |
itsbilal
approved these changes
Feb 17, 2021
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @miretskiy and @solongordon)
|
TFTR! bors r+ |
|
Build failed (retrying...): |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous commit removed this method from the interface, and this commit
follows up to remove the method entirely. This is done in a similar
fashion - by changing to using
QueryRowExWithCols(when at most onerow is expected) and to using the iterator API (avoiding the buffering
of rows in all cases).
Addresses: #48595.
Release note: None