Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kv: add TestStoreRangeSplitAndMergeWithGlobalReads #60753

Merged

Commits on Feb 20, 2021

  1. kv: add TestStoreRangeSplitAndMergeWithGlobalReads

    Made possible by cockroachdb#60567.
    
    This commit adds a new test called TestStoreRangeSplitAndMergeWithGlobalReads
    that tests that a range configured to serve global reads can be split and
    merged. In essence, this tests whether the split and merge transactions can
    handle having their timestamp bumped by the closed timestamp on the ranges
    they're operating on.
    
    The test revealed that range merges did have issues in these cases, because
    SubsumeRequests assumed that the intent on the RHS's local descriptor was below
    the node's HLC clock. This is no longer always true, so we now perform the
    inconsistent scan at hlc.MaxTimestamp, just like QueryIntent requests do.
    nvanbenschoten committed Feb 20, 2021
    Configuration menu
    Copy the full SHA
    1183dc8 View commit details
    Browse the repository at this point in the history