Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: show replica type on the range report page #61113

Merged

Conversation

aayushshah15
Copy link
Contributor

@aayushshah15 aayushshah15 commented Feb 25, 2021

Resolves #59677

Release justification: observability improvement

Release note (ui change): the range report page on the admin ui will now
also show each of the replica's types

Release justification: observability improvement

Release note (ui change): the range report page on the admin ui will now
also show each of the replica's types
@aayushshah15 aayushshah15 requested a review from a team February 25, 2021 07:02
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Member

@nvanbenschoten nvanbenschoten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm_strong:

@dhartunian do you mind giving this a pass as well?

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

Copy link
Collaborator

@nkodali nkodali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm_strong:

Reviewable status: :shipit: complete! 2 of 0 LGTMs obtained

@aayushshah15
Copy link
Contributor Author

TFTRs!

bors r+

@craig
Copy link
Contributor

craig bot commented Feb 25, 2021

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Feb 26, 2021

Build succeeded:

@craig craig bot merged commit 8f612b4 into cockroachdb:master Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kvserver, adminui: update range debug report to show replica type
4 participants