sql: fix SHOW TABLES FROM db stats display #61191
Merged
+121
−102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
RichardJCai
approved these changes
Feb 26, 2021
Release justification: low-risk bug fix to existing functionality. Release note (bug fix): The `SHOW TABLES FROM database` command would always show a NULL estimated_row_count if inspecting a database that was not the current database. This is now fixed.
rafiss
force-pushed
the
show-tables-from-db-stats
branch
from
7049baa
to
fe801c7
Compare
|
tftr! bors r=RichardJCai |
|
Build succeeded: |
craig bot
pushed a commit
that referenced
this pull request
Feb 27, 2021
61215: sql: deflake TestPGPreparedQuery r=RaduBerinde,rytaft a=rafiss A recent change to stats in SHOW TABLES made this test flaky. Stats are now read with AOST -10s by default, but for tests like this we need to modify this. See #60953 and #61191 Release justification: test-only change Release note: None Co-authored-by: Rafi Shamim <rafi@cockroachlabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #58652
Release justification: low-risk bug fix to existing functionality.
Release note (bug fix): The
SHOW TABLES FROM databasecommand wouldalways show a NULL estimated_row_count if inspecting a database that was
not the current database. This is now fixed.