Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storageccl: use chunked encryption for new backups #61841

Merged
merged 1 commit into from
Mar 11, 2021
Merged

storageccl: use chunked encryption for new backups #61841

merged 1 commit into from
Mar 11, 2021

Conversation

dt
Copy link
Member

@dt dt commented Mar 11, 2021

Release note: none.

@dt dt requested review from pbardea and a team March 11, 2021 14:09
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@dt dt force-pushed the backup-chunked-encryption branch from 8200cc7 to c1d2560 Compare March 11, 2021 16:59
pbardea
pbardea approved these changes Mar 11, 2021
View reviewed changes
Copy link
Contributor

@pbardea pbardea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to suggest a TODO to remind us to remove the cluster setting check, but I supposed we can get rid of it pretty quickly on master. :)

@dt
Copy link
Member Author

dt commented Mar 11, 2021

yeah, I'll delete it on master ~immediately.

@dt
Copy link
Member Author

dt commented Mar 11, 2021

TFTR!

bors r+

@craig
Copy link
Contributor

craig bot commented Mar 11, 2021

Build succeeded:

@craig craig bot merged commit 2b8d784 into cockroachdb:master Mar 11, 2021
@dt dt mentioned this pull request Mar 15, 2021
Merged
@dt dt deleted the backup-chunked-encryption branch March 22, 2021 22:39
@rafiss rafiss added this to the 21.1 milestone Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pbardea pbardea pbardea approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
21.1
Development

Successfully merging this pull request may close these issues.
4 participants
@dt @cockroach-teamcity @pbardea @rafiss