sql: Re-enable multi_region_backup test #62954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With cockroachdb#60835 merged, this test no longer flakes. I've stressed it on my GCE worker now for a while an it's all good. Resolves cockroachdb#60773. Release note: None
|
This change is |
arulajmani
approved these changes
Apr 1, 2021
There was a problem hiding this comment.
This thing shook out a few things! 🎉
Reviewable status:
complete! 0 of 0 LGTMs obtained
|
TFTR!
bors r=arulajmani
…On Thu, Apr 1, 2021 at 10:30 AM Arul Ajmani ***@***.***> wrote:
***@***.**** approved this pull request.
This thing shook out a few things! 🎉
*Reviewable
<https://reviewable.io/reviews/cockroachdb/cockroach/62954#-:-MXCpjtw1pc1aBvDAGRq:b-16wwb0>*
status: [image:
] complete! 0 of 0 LGTMs obtained
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#62954 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEMXVOSQPOMI2RNXQYYJXRTTGR7RNANCNFSM42HCCSNQ>
.
|
|
Build failed: |
|
flake. Retrying. bors r=arulajmani |
|
Build failed (retrying...): |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #60835 merged, this test no longer flakes. I've stressed it on my
GCE worker now for a while an it's all good.
Resolves #60773.
Release note: None