-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cliccl/debug_backup.go: refactor backup inspection tool #63309
Merged
craig
merged 1 commit into
cockroachdb:master
from
Elliebababa:refactor_backup_cli_tool
Apr 22, 2021
Merged
cliccl/debug_backup.go: refactor backup inspection tool #63309
craig
merged 1 commit into
cockroachdb:master
from
Elliebababa:refactor_backup_cli_tool
Apr 22, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elliebababa
force-pushed
the
refactor_backup_cli_tool
branch
3 times, most recently
from
April 8, 2021 20:22
0c95fd6
to
58a0f63
Compare
pbardea
approved these changes
Apr 9, 2021
Elliebababa
force-pushed
the
refactor_backup_cli_tool
branch
3 times, most recently
from
April 12, 2021 14:11
3e92e36
to
593dc5c
Compare
knz
suggested changes
Apr 12, 2021
Elliebababa
force-pushed
the
refactor_backup_cli_tool
branch
from
April 12, 2021 17:27
593dc5c
to
cb4148b
Compare
pbardea
approved these changes
Apr 19, 2021
Elliebababa
force-pushed
the
refactor_backup_cli_tool
branch
5 times, most recently
from
April 21, 2021 18:56
f2efdfa
to
5073a93
Compare
Previously, cli backup inspection tool was incorporated in cliccl/load.go. Both the command and syntax are confusing in terms of backup inspection. This patch refactors the naming and syntax of the tool and hand the tool under `cockroach debug`, so that it makes more sense when using it to debug backups. Release note (cli change): Backup inspection used to be done via `cockroach load show ..`, which was confusing to users with ambiguous verbs in the command chain. We refactor the syntax of tool and make the syntax more clear and indicative for users to debug backups. The changes are: `load show summary <backup_url>` -> `debug backup show <backup_url>` `load show incremental <backup_url>` -> `debug backup list-incremental <backup_url>` `load show backups <collection_url>` -> `debug backup list-backups <collection_url>` `load show data <table_name> <backup_url> -> `debug backup export <backup_url> --table=<table_name>`
Elliebababa
force-pushed
the
refactor_backup_cli_tool
branch
from
April 21, 2021 21:02
5073a93
to
3caed9e
Compare
bors r=pbardea |
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, cli backup inspection tool was incorporated
in cliccl/load.go. Both the command and syntax are
confusing in terms of backup inspection.
This patch refactors the naming and syntax of the tool
and hang the tool under
cockroach debug
, so thatit makes more sense when using it to debug backups.
Release note (cli change): Backup inspection used to be done via
cockroach load show ..
, which was confusing to users withambiguous verbs in the command chain. We refactor the syntax of
tool and make the syntax more clear and indicative for users to
debug backups. The changes are:
load show summary <backup_url>
->debug backup show <backup_url>
load show incremental <backup_url>
->debug backup list-incremental <backup_url>
load show backups <collection_url>
->debug backup list-backups <collection_url>
load show data <table_name> <backup_url>
->debug backup export <backup_url> --table=<table_name> [--destination=</path/to/export>]