Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: retry register.cockrachdb.com requests #64070

Merged
merged 1 commit into from
Apr 22, 2021

Conversation

stevendanna
Copy link
Collaborator

Retry transient problems getting a developer license. We may want to
avoid the retries here as a forcing function to make that service more
reliable, but given that we might see timeouts from non-service
related local networking problems, I'd prefer to not fail the test run
because of a single curl failure.

Release note: None

Retry transient problems getting a developer license. We may want to
avoid the retries here as a forcing function to make that service more
reliable, but given that we might see timeouts from non-service
related local networking problems, I'd prefer to not fail the test run
because of a single curl failure.

Release note: None
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Member

@rail rail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, :shipit:

@stevendanna
Copy link
Collaborator Author

TFTR!

bors r=rail

@craig
Copy link
Contributor

craig bot commented Apr 22, 2021

Build succeeded:

@craig craig bot merged commit 5f40d69 into cockroachdb:master Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants