roachtest/tests: adjust sqlsmith slightly #68990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adjusts `sqlsmith` roachtest slightly so that vectorized panic injection occurs with 50% probability (instead of 100%). This is done to check whether the panic injection is the root cause of the inbox communication errors we have been seeing sporadically. Release note: None
|
This change is |
mgartner
approved these changes
Aug 16, 2021
There was a problem hiding this comment.
So you expect the rate of these errors to be reduced by half? Do you have an accurate way of measuring this rate?
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @rytaft and @tbg)
|
I expect a bit more: namely, that the rate of errors is reduced by half and - what's more important - that all errors will occur when we did use the vectorized panic injection. I plan to let this change "bake" for a month or two, and I expect that we'll see on the order of 5-10 errors and hoping that all of them will be when the panic injection is used. TFTR! bors r+ |
|
Build failed (retrying...): |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adjusts
sqlsmithroachtest slightly so that vectorizedpanic injection occurs with 50% probability (instead of 100%). This is
done to check whether the panic injection is the root cause of the inbox
communication errors we have been seeing sporadically.
Informs: #66174.
Release note: None