sql: implement information_schema.{_pg_truetypid, _pg_truetypmod, _pg_char_max_length} #69913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
22 tasks
otan
approved these changes
Sep 12, 2021
rafiss
requested changes
Sep 13, 2021
…a._pg_truetypmod Needed for cockroachdb#69010. This commit adds implementations for the `information_schema._pg_truetypid` and `information_schema._pg_truetypmod` builtin functions. These functions return the "true" type ID and modifier, disregarding indirection introduced by domain types. The builtins are implemented as user-defined functions in Postgres here: https://github.com/postgres/postgres/blob/master/src/backend/catalog/information_schema.sql Release justification: None, waiting for v22.1. Release note (sql change): The `information_schema._pg_truetypid` and `information_schema._pg_truetypmod` builtin functions are now supported, which improve compatibility with PostgreSQL.
Needed for cockroachdb#69010. This commit adds implementations for the `information_schema._pg_char_max_length` builtin function. This functions returns the maximum character length of a type with the provided ID and modifier. The builtin is implemented as a user-defined function in Postgres here: https://github.com/postgres/postgres/blob/master/src/backend/catalog/information_schema.sql Release justification: None, waiting for v22.1. Release note (sql change): The `information_schema._pg_char_max_length` builtin function is now supported, which improves compatibility with PostgreSQL.
nvanbenschoten
force-pushed
the
nvanbenschoten/pg_truetypmod
branch
from
a8a419c to
3d9b5cd
Compare
Done. TFTRs! |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for #69010.
This PR adds implementations for the following three builtin functions
information_schema._pg_truetypidinformation_schema._pg_truetypmodinformation_schema._pg_char_max_lengthThe first two functions return the "true" type ID and modifier, disregarding indirection introduced by domain types. The third returns the maximum character length of a type with the provided ID and modifier.
The builtins are implemented as user-defined functions in Postgres here: https://github.com/postgres/postgres/blob/master/src/backend/catalog/information_schema.sql
Combined with #69909 and #69911, this PR unlocks these two gnarly introspection queries in PostgREST:
Release justification: None, waiting for v22.1.