[draft] storage: test and document pushing intent across epochs #69921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I haven't looked at this code in a while, but while my assumption was that if a ResolveIntent comes in at a newer epoch, we would keep the existing intent and rewrite it to that epoch, but apparently we "just" remove it. This behavior might make sense in practice (now that our concurrency control is cooperative), but it was not what I remembered, and plays a prominent role in the correctness bug cockroachdb#69414. Still need to figure out what to do with this. Comments definitely refer to the behavior I remember. It's possible that we changed this by accident. Will investigate more. Release justification: testing improvement related to release blocker cockroachdb#69414. Release note: None
|
This change is |
|
We discussed it and we're all equally confused, but it is what it is and always has been. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't looked at this code in a while, but while my assumption was
that if a ResolveIntent comes in at a newer epoch, we would keep the
existing intent and rewrite it to that epoch, but apparently we "just"
remove it.
This behavior might make sense in practice (now that our concurrency
control is cooperative), but it was not what I remembered, and plays
a prominent role in the correctness bug #69414.
Still need to figure out what to do with this. Comments definitely
refer to the behavior I remember. It's possible that we changed this
by accident. Will investigate more.
Release justification: testing improvement related to release blocker #69414.
Release note: None