stats: add a histogram version number #69944
Conversation
|
This change is |
There was a problem hiding this comment.
Reviewed 28 of 28 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @RaduBerinde and @rytaft)
pkg/sql/stats/histogram.go, line 39 at r1 (raw file):
// ATTENTION: When updating this field, add a brief description of what // changed to the version history below. const HistVersion HistogramVersion = 1
Does this need to be exported?
pkg/sql/stats/histogram.go, line 52 at r1 (raw file):
- Version: 0 - Initial histogram implementation.
Should we note here that Version 0 histograms won't have a version field?
There was a problem hiding this comment.
TFTR!
Reviewable status:
pkg/sql/stats/histogram.go, line 39 at r1 (raw file):
Previously, mgartner (Marcus Gartner) wrote…
Does this need to be exported?
Nope! Done.
pkg/sql/stats/histogram.go, line 52 at r1 (raw file):
Previously, mgartner (Marcus Gartner) wrote…
Should we note here that Version 0 histograms won't have a version field?
Done.
There was a problem hiding this comment.
Reviewable status:
pkg/sql/stats/histogram.go, line 54 at r2 (raw file):
- Version: 0 - Initial histogram implementation. The version field is omitted on Version 0
[nit] I would say histogram implementations up to and including 21.1.x.
This commit adds a histogram version number to the HistogramData proto. This will allow us to identify what logic was used to construct a particular histogram and possibly debug future issues. Release note: None Release justification: Low risk, high benefit change to existing functionality.
rytaft
force-pushed
the
hist-version
branch
from
78191f2
to
2939e1d
Compare
There was a problem hiding this comment.
bors r+
Reviewable status:
pkg/sql/stats/histogram.go, line 54 at r2 (raw file):
Previously, RaduBerinde wrote…
[nit] I would say histogram implementations up to and including 21.1.x.
Done.
|
Build succeeded: |
This commit adds a histogram version number to the
HistogramDataproto. This will allow us to identify what logic was used to construct
a particular histogram and possibly debug future issues.
Release note: None
Release justification: Low risk, high benefit change to existing
functionality.