Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor: bump Pebble to 6c12d67b83e6 #69967

Merged

Conversation

jbowens
Copy link
Collaborator

@jbowens jbowens commented Sep 9, 2021

6c12d67 internal/metamorphic: randomize FormatMajorVersion
e82fb10 db: randomize format major version in unit tests
535b8d6 db: add FormatUpgrade event to EventListener
53dda0f db: introduce format major version
8ec1a49 vfs/atomicfs: add ReadMarker
daf93f0 sstable: Free cache value when checksum type is corrupt
d89613d metamorphic: randomly use disk for tests
e3b6bec metamorphic: transform percentage of SINGLEDEL ops to DELETE ops
41239f8 db: add test demonstrating current SINGLEDEL behavior

Release note: none

Release justification: non-production code changes, and bug fix
necessary for a release blocker.

6c12d67 internal/metamorphic: randomize FormatMajorVersion
e82fb10 db: randomize format major version in unit tests
535b8d6 db: add FormatUpgrade event to EventListener
53dda0f db: introduce format major version
8ec1a49 vfs/atomicfs: add ReadMarker
daf93f0 sstable: Free cache value when checksum type is corrupt
d89613d metamorphic: randomly use disk for tests
e3b6bec metamorphic: transform percentage of SINGLEDEL ops to DELETE ops
41239f8 db: add test demonstrating current SINGLEDEL behavior

Release note: none

Release justification: non-production code changes, and bug fix
necessary for a release blocker.
@jbowens jbowens requested a review from a team September 9, 2021 16:30
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@bananabrick bananabrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @jbowens)

Copy link
Collaborator

@nicktrav nicktrav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @jbowens)

@jbowens
Copy link
Collaborator Author

jbowens commented Sep 9, 2021

TFTRs!

bors r+

@craig
Copy link
Contributor

craig bot commented Sep 9, 2021

Build failed:

@jbowens
Copy link
Collaborator Author

jbowens commented Sep 9, 2021

bors cancel

@jbowens
Copy link
Collaborator Author

jbowens commented Sep 9, 2021

bors r+

@craig
Copy link
Contributor

craig bot commented Sep 9, 2021

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Sep 9, 2021

This PR was included in a batch that was canceled, it will be automatically retried

@craig
Copy link
Contributor

craig bot commented Sep 9, 2021

Build failed (retrying...):

@jbowens
Copy link
Collaborator Author

jbowens commented Sep 9, 2021

bors r+

@craig
Copy link
Contributor

craig bot commented Sep 9, 2021

Already running a review

@craig
Copy link
Contributor

craig bot commented Sep 10, 2021

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Sep 10, 2021

Build succeeded:

@craig craig bot merged commit 5b40b19 into cockroachdb:master Sep 10, 2021
@jbowens jbowens deleted the jackson/pebble-master-6c12d67b83e6 branch September 10, 2021 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants