Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-21.2: sql: preserve tuple types when decoding #70392

Merged
merged 1 commit into from
Nov 19, 2021

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Sep 18, 2021

Backport 1/1 commits from #70375 on behalf of @jordanlewis.

/cc @cockroachdb/release


Fixes #70360

Previously, when decoding tuples sent across the wire in DistSQL, tuple
labels were not preserved due to an oversight.

This oversight is now corrected, and tuple labels are now properly
preserved in all queries.

Release note (bug fix): fix a bug preventing tuple type labels from
being propagated across queries when run under DistSQL.


Release justification:

Previously, when decoding tuples sent across the wire in DistSQL, tuple
labels were not preserved due to an oversight.

This oversight is now corrected, and tuple labels are now properly
preserved in all queries.

Release note (bug fix): fix a bug preventing tuple type labels from
being propagated across queries when run under DistSQL.
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-21.2-70375 branch from 0033f15 to 192a89f Compare September 18, 2021 17:35
@blathers-crl
Copy link
Author

blathers-crl bot commented Sep 18, 2021

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Member

@yuzefovich yuzefovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: for 21.2.1.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @jordanlewis and @rafiss)

@rafiss rafiss merged commit dfed5b0 into release-21.2 Nov 19, 2021
@rafiss rafiss deleted the blathers/backport-release-21.2-70375 branch November 19, 2021 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants