changefeedccl: Add metrics to changefeed throttle. #70647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
miretskiy
force-pushed
the
throttle
branch
4 times, most recently
from
f747979
to
982ac01
Compare
Add metrics to changefeed traffic throttler. Release Justification: Small observability changes to the existing functionality. Release Notes: None
|
friendly ping: @HonoreDB |
HonoreDB
approved these changes
Sep 30, 2021
There was a problem hiding this comment.
LGTM
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @miretskiy)
|
tftr |
|
🔒 Permission denied Existing reviewers: click here to make miretskiy a reviewer |
|
bors r+ |
|
🔒 Permission denied Existing reviewers: click here to make miretskiy a reviewer |
|
bors r+ |
|
Build failed (retrying...): |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add metrics to changefeed traffic throttler.
Release Justification: Small observability changes to the existing functionality.
Release Notes: None