Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util/tracing: fix an edge case for active span registration #70850

Merged
merged 2 commits into from
Oct 1, 2021
Merged

util/tracing: fix an edge case for active span registration #70850

merged 2 commits into from
Oct 1, 2021

Commits on Oct 1, 2021

  1. util/tracing: introduce helper Span.IsNoop() method 

    This was hidden in an internal helper, but it's such a common concern
that it deserves better ergonomics, and it even deserves to be public.

Release note: None
    @andreimatei
    andreimatei committed Oct 1, 2021
    Configuration menu
    Copy the full SHA
    1150e72 View commit details
    Browse the repository at this point in the history

  2. util/tracing: fix an edge case for active span registration 

    Before this patch, a span with a no-op parent (as opposed to a span
with no parent), would not be present in the active spans registry. The
code was confused: the span didn't qualify as a "local root" because it
had a local parent, but of course it also wasn't really recorded by the
local parent cause a no-op span can't record anything. As such, the span
in question was missing from the registry.
This patch makes a span with a no-op parent behave like a root span.

Release note: None
    @andreimatei
    andreimatei committed Oct 1, 2021
    Configuration menu
    Copy the full SHA
    f299cf2 View commit details
    Browse the repository at this point in the history