Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

instancestorage: Add SQL test for sql_instances. #70950

Merged
merged 1 commit into from
Oct 13, 2021

Conversation

rimadeodhar
Copy link
Collaborator

This PR adds a unit test to verify that the sql_instances
table can be accessed through SQL API.

Release note: None

@rimadeodhar rimadeodhar requested review from knz and a team September 30, 2021 20:20
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@knz knz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @rimadeodhar)

This PR adds a unit test to verify that the sql_instances
table can be accessed through SQL API.

Release note: None
@rimadeodhar
Copy link
Collaborator Author

TFTR!

bors r=knz

@craig
Copy link
Contributor

craig bot commented Oct 13, 2021

Build succeeded:

@craig craig bot merged commit c908959 into cockroachdb:master Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants