opt: fix implicit lateral for SRFs when using JOIN syntax #71396
Conversation
|
This change is |
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @rytaft)
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:
pkg/sql/opt/optbuilder/join.go, line 44 at r1 (raw file):
// the left side. if t, ok := join.Right.(*tree.AliasedTableExpr); ok && t.Lateral { telemetry.Inc(sqltelemetry.LateralJoinUseCounter)
do we still need this telemetry?
RaduBerinde
force-pushed
the
implicit-lateral-join
branch
from
9d01659
to
7cc05b4
Compare
There was a problem hiding this comment.
Reviewable status:
pkg/sql/opt/optbuilder/join.go, line 44 at r1 (raw file):
Previously, rytaft (Rebecca Taft) wrote…
do we still need this telemetry?
Yeah, I removed it accidentally (and some tests failed on CI because of it). Moved it to exprIsLateral.
When SRFs are used as a table, they imply that the join is lateral. This works for the multiple table syntax, but not for the JOIN syntax. This commit addresses this omission. Fixes cockroachdb#70342. Release note (bug fix): Fixes an incorrect "no data source matches prefix" error for queries that use a set-returning function on the right-hand side of a `JOIN` (unless `LATERAL` is explicitly specified).
RaduBerinde
force-pushed
the
implicit-lateral-join
branch
from
7cc05b4
to
9e8d9be
Compare
There was a problem hiding this comment.
Reviewed 1 of 2 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status:
|
bors r+ |
|
Build succeeded: |
When SRFs are used as a table, they imply that the join is lateral.
This works for the multiple table syntax, but not for the JOIN syntax.
This commit addresses this omission.
Fixes #70342.
Release note (bug fix): Fixes an incorrect "no data source matches
prefix" error for queries that use a set-returning function on the
right-hand side of a
JOIN(unlessLATERALis explicitlyspecified).