release-21.1: import: add support for non-admin outbound flag #72444
Conversation
This adds support to IMPORT for the outbound/implicit access without admin role flag that was previously added to BACKUP, SHOW BACKUP, RESTORE, and EXPORT in cockroachdb#71594. Release note (ops change): IMPORT now also allows non-admin access to some previously admin-only URIs if --external-io-enable-non-admin-implicit-access.
|
This change is |
dt
changed the title
|
Can probably ignore the release note on this one since the note on #71794 already claimed to do this, and this is just catching one case that was dropped during the backport process. |
|
I'm confused - why does it say that I merged this? I don't remember doing that, but I did merge #72391 to 21.1 branch at about the same time 🤷 |
|
@yuzefovich I'm not sure, I clicked merge and got an error so I tried again and got a conflicts rejection which seemed to be because the commits were now on the 21.1 branch... but the PR was still shown as unmerged. Just guessing, but I suspect some queue message is generated on commits added but got dropped, so it didn't close the PR, but then your merge's event picked it up and updated it, just with your name attached? |
This adds support to IMPORT for the outbound/implicit access without
admin role flag that was previously added to BACKUP, SHOW BACKUP, RESTORE,
and EXPORT in #71594.
Release note (ops change): IMPORT now also allows non-admin access to some previously admin-only URIs if --external-io-enable-non-admin-implicit-access is passed, following its prior addition to BACKUP, RESTORE, and EXPORT.
Release justification: bug fix.