Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: refactor internal executor factory to accept init function #73193

Closed

Commits on Nov 26, 2021

  1. sql: refator internal executor factory to accept init function

    This change refactors the InternalExecutorFactory to take in
    a closure that allows injecting external state into a new internal
    executor.
    
    Release note: None
    adityamaru committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    8137ebb View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2021

  1. sql,*ccl: remove InternalExecutor from ExecCfg

    In a bid to make the InternalExecutor more tightly bound
    with certain conn executor state such as transaction, session
    data, extraTxnState (including descs collection), this patch
    removes the `InternalExecutor` field from the executor config.
    In this way consumers of the IE cannot just run queries off of
    this free floating instance of the IE, but instead have to
    initialize a new IE in the context of the surrounding txn.
    
    The `InternalExecFactory` currently takes a closure that allows
    for injecting necessary state into a newly created IE, but one
    could imagine a future where we use typed parameters to force
    all users to bind the IE with the surrounding state it is being
    used in.
    
    Release note: None
    adityamaru committed Nov 28, 2021
    Configuration menu
    Copy the full SHA
    323561b View commit details
    Browse the repository at this point in the history