tracing: optimize span.Finish #73398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't read the clock unnecessarily and also use the more efficient timeutil.Since(t) when reading it is necessary. This clock reading was showing up in profiles when running with tracing enabled, and is confirmed by a micro-benchmark: Tracer_StartSpanCtx/opts=real-32 696ns ± 1% 593ns ± 1% -14.74% (p=0.008 n=5+5) Release note: None
|
This change is |
rimadeodhar
approved these changes
Dec 7, 2021
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @abarganier)
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't read the clock unnecessarily and also use the more efficient
timeutil.Since(t) when reading it is necessary.
This clock reading was showing up in profiles when running with tracing
enabled, and is confirmed by a micro-benchmark:
Tracer_StartSpanCtx/opts=real-32 696ns ± 1% 593ns ± 1% -14.74% (p=0.008 n=5+5)
Release note: None