Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: add test asserting CREATE/USAGE on public schema #73862

Merged
merged 1 commit into from
Dec 17, 2021

Conversation

rafiss
Copy link
Collaborator

@rafiss rafiss commented Dec 15, 2021

refs #70266

The public schema currently always has CREATE/USAGE privileges
for the public role. Add a test that confirms this.

Release note: None

@rafiss rafiss requested review from RichardJCai, a team and shermanCRL and removed request for a team December 15, 2021 19:38
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@otan otan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/assering/asserting/

@rafiss rafiss changed the title sql: add test assering CREATE/USAGE on public schema sql: add test asserting CREATE/USAGE on public schema Dec 16, 2021
The public schema currently always has CREATE/USAGE privileges
for the public role. Add a test that confirms this.

Release note: None
@rafiss rafiss force-pushed the public-schema-public-role-privs branch from f4bd411 to 99eeb09 Compare December 16, 2021 20:22
@rafiss
Copy link
Collaborator Author

rafiss commented Dec 16, 2021

bors r=otan

@craig
Copy link
Contributor

craig bot commented Dec 16, 2021

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Dec 16, 2021

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Dec 17, 2021

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Dec 17, 2021

Build succeeded:

@craig craig bot merged commit 089affc into cockroachdb:master Dec 17, 2021
@rafiss rafiss deleted the public-schema-public-role-privs branch January 13, 2022 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants