Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sqlsmith: don't compare voids for joins #73954

Merged
merged 2 commits into from
Dec 17, 2021

Conversation

otan
Copy link
Contributor

@otan otan commented Dec 17, 2021

No comparison expr is defined on voids, so don't generate comparisons
for them.

Resolves #73901
Resolves #73898
Resolves #73777

Release note: None

No comparison expr is defined on voids, so don't generate comparisons
for them.

Release note: None
@otan otan requested a review from rafiss December 17, 2021 00:23
@otan otan requested a review from a team as a code owner December 17, 2021 00:23
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@rafiss rafiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@otan
Copy link
Contributor Author

otan commented Dec 17, 2021

bors r=rafiss

@craig
Copy link
Contributor

craig bot commented Dec 17, 2021

Canceled.

@otan
Copy link
Contributor Author

otan commented Dec 17, 2021

bors r=rafiss

@craig
Copy link
Contributor

craig bot commented Dec 17, 2021

Canceled.

@otan
Copy link
Contributor Author

otan commented Dec 17, 2021

bors r=rafiss

@craig
Copy link
Contributor

craig bot commented Dec 17, 2021

Build succeeded:

@craig craig bot merged commit 089affc into cockroachdb:master Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants