sql: revert removal of datum size adjustment #74229
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the WithScan columns of cascade FK updates were given the type of the child table's target column. This was incorrect when the parent column type did not match. This commit fixes the issue by given the WithScan columns the type of the buffered columns used to update the parent relation. This did not cause any known bugs, but it is required to implement assignment casts with FK cascades. Release note: None
Fixes cockroachdb#70628 Release note: None
Adjusting INSERT, UPDATE, and UPSERT values right before they are written in the execution engine is no longer necessary with assignment casts, and it is incorrect (see cockroachdb#69665). However, we will continue to perform these adjustments to avoid regressions that assignment casts may cause until we have more confidene in assignment casts. In test builds, an assertion has been added to ensure that the adjustments have no effect, which should help catch potential bugs in assignment casts. Release note: None
|
This change is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusting INSERT, UPDATE, and UPSERT values right before they are
written in the execution engine is no longer necessary with assignment
casts, and it is incorrect (see #69665). However, we will continue to
perform these adjustments to avoid regressions that assignment casts may
cause until we have more confidene in assignment casts. In test builds,
an assertion has been added to ensure that the adjustments have no
effect, which should help catch potential bugs in assignment casts.
Release note: None