row: fetcher cleanup and improvements #75261
Conversation
|
This change is |
There was a problem hiding this comment.
Reviewed 9 of 9 files at r1, 1 of 1 files at r2, 2 of 2 files at r3, 2 of 2 files at r4, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @RaduBerinde)
pkg/sql/catalog/descpb/BUILD.bazel, line 14 at r1 (raw file):
"descriptor.go", "index.go", "index_fetch.pb.go",
Changes in this file seem suspicious.
pkg/sql/row/fetcher.go, line 731 at r3 (raw file):
} // DecodeIndexKey decodes an index key and returns the remaining key and wheter
nit: s/wheter/whether/.
RaduBerinde
force-pushed
the
row-fetcher-cleanup
branch
from
475b766
to
4207ee6
Compare
Release note: None
This moves around some code to make it clear that it's only relevant in a specific case. Release note: None
Renaming to DecodeIndexKey and removing return value which is no longer useful. Release note: None
- improve comment for `indexKey`; - unexport NextKey; - slightly change the return value of nextKey to simplify the logic (the semantic difference is what the first call returns, which is not used); - use numKeysPerRow instead of counting the total families; this enables the faster paths for more cases. Release note: None
RaduBerinde
force-pushed
the
row-fetcher-cleanup
branch
from
4207ee6
to
a6f5016
Compare
There was a problem hiding this comment.
TFTR!
Reviewable status:
pkg/sql/catalog/descpb/BUILD.bazel, line 14 at r1 (raw file):
Previously, yuzefovich (Yahor Yuzefovich) wrote…
Changes in this file seem suspicious.
Nice catch, it was a leftover pb.go file from another branch
|
Test failure is an unrelated flake. bors r+ |
|
This PR was included in a batch that was canceled, it will be automatically retried |
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
Build succeeded: |
rowenc: remove deprecated return from DecodeIndexKey
Release note: None
row: minor cleanup around foundNull
This moves around some code to make it clear that it's only relevant in
a specific case.
Release note: None
row: clean up ReadIndexKey
Renaming to DecodeIndexKey and removing return value which is no
longer useful.
Release note: None
row: more Fetcher cleanup
indexKey;(the semantic difference is what the first call returns, which is
not used);
enables the faster paths for more cases.
Release note: None