server: remove contention event registry from baseStatusServer #75835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
20 tasks
Azhng
force-pushed
the
status-remove-contention-registry
branch
from
37a26db
to
4a4ff9a
Compare
yuzefovich
approved these changes
Feb 2, 2022
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @Azhng)
pkg/server/tenant.go, line 169 at r1 (raw file):
args.rpcContext, args.stopper, ) contentionRegistry := contention.NewRegistry()
nit: why not squash these two lines into one?
maryliag
approved these changes
Feb 2, 2022
There was a problem hiding this comment.
Reviewed 3 of 4 files at r1, all commit messages.
Reviewable status:
Previously, baseStatusServer holds a reference to contention.Registry. This reference of contention.Registry is used to power the /ListContentionEvents endpoint. However, this is not ideal for two reasons: 1. baseStatusServer already holds a reference to *server.SQLServer, which in turn contains contention.Registry through its ExecutorConfig field. This means that there's no good reason to have another field in baseStatusServer to hold this additional reference. 2. The ongoing contention event registry work will make contention registry depend on status server to perform transaction ID resolution protocol. As it stand today, the status server's construction depends on the creation of contention.Registry. By introducing transaction ID resolution protocol into contention.Registry, we will be introducing a cyclical reference, which can lead to ugly API design. This commit removes the baseStatusServer's reference on contention.Registry, and instead directly fetching from executor config. Release note: None
Azhng
force-pushed
the
status-remove-contention-registry
branch
from
4a4ff9a
to
39690fc
Compare
|
TFTR! bors r+ |
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, baseStatusServer holds a reference to contention.Registry.
This reference of contention.Registry is used to power the
/ListContentionEvents endpoint. However, this is not ideal for two
reasons:
which in turn contains contention.Registry through its ExecutorConfig
field. This means that there's no good reason to have another field
in baseStatusServer to hold this additional reference.
registry depend on status server to perform transaction ID resolution
protocol. As it stand today, the status server's construction depends
on the creation of contention.Registry. By introducing transaction ID
resolution protocol into contention.Registry, we will be introducing
a cyclical reference, which can lead to ugly API design.
This commit removes the baseStatusServer's reference on
contention.Registry, and instead directly fetching from executor config.
Release note: None