build: extend pebble metamorphic timeout; lower operation count #76629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
tbg
approved these changes
Feb 16, 2022
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @nicktrav)
jbowens
approved these changes
Feb 16, 2022
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:
The Pebble metamorphic test runs have been timing out due to single runs taking longer for worst-case configurations. Increase the governing timeout from just over three hours to four hours. This gives more time to a metamorphic test run that started close to the end of the three hour window to complete. Lower the upper bound on the operation count random distribution from 25k ops to 10k ops. This will shorten the time for each run, on average, while allowing more configurations to be tested overall. Update the reproduction message in the Pebble formatter. Related to cockroachdb/pebble#1514. Release note: None
nicktrav
force-pushed
the
nickt.pebble-meta
branch
from
31d2b2f
to
639aecd
Compare
|
TFTRs! bors r=tbg,jbowens |
|
Build failed (retrying...): |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Pebble metamorphic test runs have been timing out due to single runs
taking longer for worst-case configurations. Increase the governing
timeout from just over three hours to four hours. This gives more time
to a metamorphic test run that started close to the end of the three
hour window to complete.
Lower the upper bound on the operation count random distribution from
25k ops to 10k ops. This will shorten the time for each run, on average,
while allowing more configurations to be tested overall.
Update the reproduction message in the Pebble formatter.
Related to cockroachdb/pebble#1514.
Release note: None