ui: change invalid lease to expired lease on problem ranges page #76757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
koorosh
reviewed
Feb 18, 2022
There was a problem hiding this comment.
@Santamaura , is it necessary to rename forth column in the table as well?
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @Annebirzin, @thtruo, and @zachlite)
When browsing the problem ranges page and invalid leases appears customers regularly are concerned with this status as they interpret it as something with the cluster is wrong which is often not the case. In order to imrpove this, the invalid lease section has been changed to expired lease and there is a description added below which explains that this status is often not a cause for concern. Release note (ui change): change invalid lease to expired lease on problem ranges page
Santamaura
force-pushed
the
fix-invalid-lease
branch
from
937496e
to
e0de475
Compare
Santamaura
commented
Feb 18, 2022
There was a problem hiding this comment.
Yes thanks for pointing that out. I've updated the column title as well.
Reviewable status:
koorosh
approved these changes
Feb 18, 2022
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:
|
bors r+ |
|
Build failed: |
|
bors retry |
|
Build succeeded: |
Annebirzin
reviewed
Feb 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When browsing the problem ranges page and invalid leases appears customers
regularly are concerned with this status as they interpret it as something
with the cluster is wrong which is often not the case. In order to imrpove this,
the invalid lease section has been changed to expired lease and there is a
description added below which explains that this status is often not a cause
for concern.
Release note (ui change): change invalid lease to expired lease on problem ranges page
Resolves: #38616