server: add store_id to hot ranges response api #76877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
koorosh
force-pushed
the
add-stores-field-to-hot-ranges-response
branch
from
6a4842b
to
669948c
Compare
dhartunian
approved these changes
Feb 28, 2022
There was a problem hiding this comment.
Reviewed 2 of 8 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @dhartunian, @koorosh, @Santamaura, and @zachlite)
pkg/server/serverpb/status.proto, line 1232 at r5 (raw file):
// schema_name provides the name of schema (if exists) for table in current range. string schema_name = 9; int32 store_id = 10 [
nit: docstring
koorosh
force-pushed
the
add-stores-field-to-hot-ranges-response
branch
from
669948c
to
3511ea6
Compare
koorosh
commented
Mar 2, 2022
There was a problem hiding this comment.
Done! Thanks!
Reviewable status:
pkg/server/serverpb/status.proto, line 1232 at r5 (raw file):
Previously, dhartunian (David Hartunian) wrote…
nit: docstring
Done!
|
bors r+ |
|
Build failed: |
koorosh
force-pushed
the
add-stores-field-to-hot-ranges-response
branch
from
3511ea6
to
ff6cf57
Compare
This change extends HotRangesResponseV2 message to include store ID data. This information can be useful to investigate cause of hot ranges. Release note: None Release justification: bug fixes and low-risk updates to new functionality
koorosh
force-pushed
the
add-stores-field-to-hot-ranges-response
branch
from
ff6cf57
to
3a24e7e
Compare
|
bors r+ |
|
Build succeeded: |
This was referenced Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change extends HotRangesResponseV2 message
to include store ID data. This information can
be useful to investigate cause of hot ranges.
Release note: None
Release justification: bug fixes and low-risk updates to new functionality
Resolves: #76160