Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changefeedccl: Fix data race in a test. #77006

Merged
merged 1 commit into from
Feb 25, 2022
Merged

changefeedccl: Fix data race in a test. #77006

merged 1 commit into from
Feb 25, 2022

Conversation

miretskiy
Copy link
Contributor

Fix data race in TestChangefeedSendError.

Release Notes: None

@miretskiy miretskiy requested a review from samiskin February 24, 2022 21:14
@miretskiy miretskiy requested a review from a team as a code owner February 24, 2022 21:14
@cockroach-teamcity
Copy link
Member

This change is Reviewable

changefeedccl: Fix data race in a test.
914f3b6 
Fix data race in TestChangefeedSendError.

Release Notes: None
@samiskin samiskin closed this Feb 25, 2022
@samiskin samiskin reopened this Feb 25, 2022
@samiskin
Copy link
Contributor

whoops

@miretskiy
Copy link
Contributor Author

bors r+

@craig
Copy link
Contributor

craig bot commented Feb 25, 2022

Build failed:

@miretskiy
Copy link
Contributor Author

bors r+

@craig craig bot merged commit 2826900 into cockroachdb:master Feb 25, 2022
@craig
Copy link
Contributor

craig bot commented Feb 25, 2022

Build succeeded:

@miretskiy miretskiy mentioned this pull request Feb 26, 2022
Merged
craig bot pushed a commit that referenced this pull request Mar 1, 2022
@samiskin
Merge #77069
93a02df 
77069: release-21.2: changefeedccl: mark kvcoord sendError as retryable r=miretskiy a=miretskiy

Backport:
  * 1/1 commits from "changefeedccl: mark kvcoord sendError as retryable" (#75517)
  * 1/1 commits from "changefeedccl: Fix data race in a test." (#77006)

Please see individual PRs for details.

/cc `@cockroachdb/release`


Co-authored-by: Shiranka Miskin <shiranka.miskin@gmail.com>
@tbg tbg mentioned this pull request Mar 24, 2022
Open
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samiskin samiskin samiskin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miretskiy @cockroach-teamcity @samiskin