Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: add cluster setting to limit max size of serialized session #77307

Merged
merged 1 commit into from
Mar 3, 2022

Conversation

rafiss
Copy link
Collaborator

@rafiss rafiss commented Mar 2, 2022

fixes #77302

The sql.session_transfer.max_session_size cluster setting can be used to
limit the max size of a session that is serialized using
crdb_internal.serialize_session.

No release note since this is not a public setting.

Release justification: high priority fix for new functionality.

Release note: None

@rafiss rafiss requested review from jaylim-crl and a team March 2, 2022 21:27
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@jaylim-crl jaylim-crl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: Thanks!

(there's a lint issue by the way)

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @rafiss)

The sql.session_transfer.max_session_size cluster setting can be used to
limit the max size of a session that is serialized using
crdb_internal.serialize_session.

No release note since this is not a public setting.

Release justification: high priority fix for new functionality.

Release note: None
@rafiss rafiss force-pushed the session-migration-followups branch from 6f771b1 to baf3d76 Compare March 3, 2022 17:54
@rafiss
Copy link
Collaborator Author

rafiss commented Mar 3, 2022

tftr!

bors r=otan,jaylim-crl

@craig craig bot merged commit 960f2b4 into cockroachdb:master Mar 3, 2022
@craig
Copy link
Contributor

craig bot commented Mar 3, 2022

Build succeeded:

@rafiss rafiss deleted the session-migration-followups branch March 4, 2022 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sql: add TenantReadOnly cluster setting to restrict returned MigratableSession size
4 participants