Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util/log: remove Safe in favor of redact.Safe #77317

Merged
merged 1 commit into from
Mar 3, 2022

Conversation

yuzefovich
Copy link
Member

My desire to make this change is to break the dependency of treewindow
on util/log (which is a part of the effort to clean up the
dependencies of execgen).

Addresses: #77234.

Release note: None

Release justification: low risk change to clean up the dependencies
a bit.

My desire to make this change is to break the dependency of `treewindow`
on `util/log` (which is a part of the effort to clean up the
dependencies of `execgen`).

Release note: None

Release justification: low risk change to clean up the dependencies
a bit.
@yuzefovich yuzefovich requested a review from knz March 3, 2022 04:08
@yuzefovich yuzefovich requested review from a team as code owners March 3, 2022 04:08
@yuzefovich yuzefovich requested a review from a team March 3, 2022 04:08
@yuzefovich yuzefovich requested a review from a team as a code owner March 3, 2022 04:08
@yuzefovich yuzefovich requested review from HonoreDB and removed request for a team March 3, 2022 04:08
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@knz knz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! 💯

@yuzefovich
Copy link
Member Author

TFTR!

bors r+

@craig
Copy link
Contributor

craig bot commented Mar 3, 2022

Build succeeded:

@craig craig bot merged commit fd15d3a into cockroachdb:master Mar 3, 2022
@yuzefovich yuzefovich deleted the execgen-1 branch March 3, 2022 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants