Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: log stdout and stderr in sstable corruption test #77328

Merged

Conversation

nicktrav
Copy link
Collaborator

@nicktrav nicktrav commented Mar 3, 2022

To aid in debugging #77321, log the contents stdout and stderr if the
manifest dump command fails.

Release justification: Tests only.

Release note: None.

To aid in debugging cockroachdb#77321, log the contents stdout and stderr if the
manifest dump command fails.

Release justification: Tests only.

Release note: None.
@nicktrav nicktrav requested a review from itsbilal March 3, 2022 15:16
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Member

@itsbilal itsbilal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @nicktrav)

@nicktrav
Copy link
Collaborator Author

nicktrav commented Mar 3, 2022

TFTR!

bors r=itsbilal

@craig
Copy link
Contributor

craig bot commented Mar 3, 2022

Build succeeded:

@craig craig bot merged commit 960f2b4 into cockroachdb:master Mar 3, 2022
@nicktrav nicktrav deleted the nickt.roachtest-sstable-corruption branch March 3, 2022 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants