Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.1: ccl/sqlproxyccl: rename tenant.Resolver to tenant.DirectoryCache #78394

Merged
merged 2 commits into from
Mar 24, 2022

Commits on Mar 21, 2022

  1. ccl/sqlproxyccl: move the TenantResolver interface to the tenant package

    Previously, the TenantResolver interface lived in the base sqlproxyccl package,
    and there was no way to enforce that the tenant.Directory struct implements
    this interface since that would result in a cyclic dependency. This commit
    moves the TenantResolver interface into the tenant package, and enforced that
    the tenant.Directory struct implements that.
    
    This would then allow us to rename the tenant.Directory struct to
    tenant.directoryCache, and the tenant.Resolver interface to
    tenant.DirectoryCache.
    
    Release note: None
    jaylim-crl committed Mar 21, 2022
    Configuration menu
    Copy the full SHA
    0145311 View commit details
    Browse the repository at this point in the history
  2. ccl/sqlproxyccl: rename tenant.Resolver to tenant.DirectoryCache

    This commit renames the tenant.Resolver interface to tenant.DirectoryCache.
    The existing Directory struct was also renamed to directoryCache to prevent
    confusions since there were previously two definitions of a "directory": one
    pointing to the cache of entries, whereas another referring to the actual
    directory server.
    
    Release note: None
    jaylim-crl committed Mar 21, 2022
    Configuration menu
    Copy the full SHA
    a11234b View commit details
    Browse the repository at this point in the history